Re: [Dev-luatex] [PATCH] luaharfbuzz: Provide interface for variable fonts

On Tue, Aug 03, 2021 at 11:51:16AM +0200, luigi scarso wrote:

On Mon, Aug 2, 2021 at 8:40 PM Marcel Fabian Krüger wrote:

...

...

1) why 2 files ?

Whenever I checkout the sources from git, svn or the web interface I get files with UNIX line ending, but some months ago you mentioned that a patch couldn't be applied because it should have used Windows line endings instead. Therefore I added a .win version with Windows line endings to avoid issues but still included the other patch since that's the one I actually tested locally.

Do you remember the email ? All code should be with UNIX line ending

Hi Luigi, Oops, looking back I realized that I remembered it incorrectly: The issue was that the file couldn't get applied because the *patch* had Windows lineendings. Not sure how that happened but anyway I stand corrected.

Sure, I added a zip of the individual patches.

...

Patches applied, but I don't have variation.c, which is mentioned in luaharfbuzz.am.patch and so variation.c.patch cannot be applied .

Actually variation.c.patch is supposed to create a new file, so it should work even if the file doesn't exists yet. Not sure how standard that format is though, it seems to be a git extension which got picked up by GNU patch but not by many other tools. I added the full file variation.c as an attachment. It belongs at source/texk/web2c/luatexdir/luaharfbuzz/src/luaharfbuzz/variation.c Best, Marcel